Skip to content

fix(all): lint warnings - add missing dependency for tests #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vbuberen merged 1 commit into from
Oct 13, 2022
Merged

fix(all): lint warnings - add missing dependency for tests #1233

vbuberen merged 1 commit into from
Oct 13, 2022

Conversation

@miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Oct 13, 2022 •
edited
Loading

Description

Fixes some static analysis warnings

Related Issues

none

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran changed the title lint: add missing dependency for tests fix: lint warnings - add missing dependency for tests Oct 13, 2022
@miquelbeltran miquelbeltran changed the title fix: lint warnings - add missing dependency for tests fix(all): lint warnings - add missing dependency for tests Oct 13, 2022
@vbuberen
Copy link
Collaborator

vbuberen commented Oct 13, 2022

Action added by you catches you 😄

@miquelbeltran
Copy link
Member Author

miquelbeltran commented Oct 13, 2022

Action added by you catches you smile

too bad it doesn't accept "lint" as a valid header :(

@vbuberen vbuberen merged commit b9c4008 into main Oct 13, 2022
@vbuberen vbuberen deleted the add-missing-flutter-test-dep branch October 13, 2022 17:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vbuberen vbuberen vbuberen approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miquelbeltran @vbuberen