-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ci(android_alarm_manager_plus): Add matrix of versions for integration tests #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,15 +23,16 @@ jobs: | |
| timeout-minutes: 30 | ||
| steps: | ||
| - name: "Checkout repository" | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 | ||
| - name: "Install Flutter" | ||
| run: ./.github/workflows/scripts/install-flutter.sh stable | ||
| - name: "Install Tools" | ||
| run: ./.github/workflows/scripts/install-tools.sh | ||
|
|
||
| # Required for Android builds | ||
| - uses: actions/setup-java@v1 | ||
| # Required for Android builds | ||
| - uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: "temurin" | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. setup-java in v2 requires to specify the distribution type, thus, this addition. |
||
| java-version: "11" | ||
|
|
||
| - name: "Build Example" | ||
|
|
@@ -40,26 +41,33 @@ jobs: | |
| android_integration_test: | ||
| runs-on: macos-latest | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| matrix: | ||
| android-api-level: [21, 26, 32] | ||
|
Comment on lines
+44
to
+46
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ohh that's cool, simpler than what I thought. |
||
|
|
||
| steps: | ||
| - name: "Checkout repository" | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 | ||
| - name: "Install Flutter" | ||
| run: ./.github/workflows/scripts/install-flutter.sh stable | ||
| - name: "Install Tools" | ||
| run: ./.github/workflows/scripts/install-tools.sh | ||
|
|
||
| # Required for Android builds | ||
| - uses: actions/setup-java@v1 | ||
| # Required for Android builds | ||
| - uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: "temurin" | ||
| java-version: "11" | ||
|
|
||
| - name: "Bootstrap Workspace" | ||
| run: melos bootstrap | ||
| - name: "Android Integration Test" | ||
| uses: reactivecircus/android-emulator-runner@v2 | ||
| with: | ||
| api-level: 30 | ||
| arch: x86_64 | ||
| api-level: ${{ matrix.android-api-level }} | ||
| cores: 3 | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| target: google_apis | ||
| arch: x86_64 | ||
| force-avd-creation: false | ||
| profile: Nexus 5X | ||
| script: ./.github/workflows/scripts/integration-test.sh android android_alarm_manager_example | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I experimented with removing this step as suggested in one of other PRs (because of https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#java saying that such runners already have Java 11), but couldn't build the project due to missing Java 11. Thus, returned the step again.