Skip to content

Conversation

@OutdatedGuy
Copy link
Contributor

Changes

  • Increase android sdk compile version to 35
  • Updates Java compatibility version to 11

  1. Overwrote all plugins with flutter create --overwrite ..... to get latest flutter template
  2. Using latest kotlin style in buid.gradle
  3. Removed the old .gradle files in favor for .gradle.kts in example app
  4. Updated ios constraints from 15.5.0 to 15.5 as apple does (wouldn't change / break anything)

fixes #758, fixes #759

@fbernaly
Copy link
Collaborator

@OutdatedGuy: could you resolve conflicts, also, update all dependencies to google_mlkit_commons: ^0.10.0, like this:

https://github.com/flutter-ml/google_ml_kit_flutter/blob/develop/packages/google_mlkit_text_recognition/pubspec.yaml#L14C3-L14C32

@OutdatedGuy
Copy link
Contributor Author

update all dependencies to google_mlkit_commons: ^0.10.0

@fbernaly Should I update them to 0.10.0 or 0.11.0? As this PR will increment google_mlkit_commons version to 0.11.0

@fbernaly
Copy link
Collaborator

to 0.10.0 because that is the version we have published. Once I publish 0.11.0 we will change the version

@OutdatedGuy OutdatedGuy requested a review from fbernaly March 19, 2025 22:15
@@ -1,14 +1,13 @@
name: google_ml_kit_example
description: Demonstrates how to use the google_ml_kit plugin.
description: "Demonstrates how to use the google_ml_kit plugin."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why in some pubspec.yaml file you added double quotes? and in other single quotes?
I would like to keep all of them unquoted.

https://stackoverflow.com/a/69850618/3610617

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flutter create command added those only around description. Seems like some flutter standard or something.

@fbernaly fbernaly merged commit bc0a1e8 into flutter-ml:develop Mar 20, 2025
2 checks passed
@fbernaly
Copy link
Collaborator

@OutdatedGuy : changes have been merged and released

@fbernaly
Copy link
Collaborator

Thanks for your contributions

@fbernaly
Copy link
Collaborator

https://github.com/flutter-ml/google_ml_kit_flutter/blob/develop/CHANGELOG.md#2025-03-20

@OutdatedGuy OutdatedGuy deleted the update-template branch March 22, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update compileSdk version to 35 Update Java Version from 8 to 11

2 participants