Skip to content

[FL-3618] Support for button indices #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 2 commits into from
Nov 10, 2023
Merged

[FL-3618] Support for button indices #47

skotopes merged 2 commits into from
Nov 10, 2023

Conversation

@gsurkov
Copy link
Member

@gsurkov gsurkov commented Oct 31, 2023

Changes:

  • Add index field to AppButtonPressRequest message (needed to uniquely address individual Infrared remote buttons which may have identical names)

@gsurkov gsurkov mentioned this pull request Oct 31, 2023
Merged
3 tasks
LionZXY
LionZXY approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@LionZXY LionZXY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

@skotopes skotopes merged commit 23ad19a into dev Nov 10, 2023
@skotopes skotopes deleted the gsurkov/3618_ir_duplicate_buttons branch November 10, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LionZXY LionZXY LionZXY approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

+1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gsurkov @skotopes @LionZXY