Skip to content

Conversation

@bettse
Copy link
Collaborator

@bettse bettse commented Dec 21, 2023

What's new

  • Fixes to the save partial flow when dealing with a non-SE card (found in discord)

Verification

  • Remove AA1/standard key from dictonary
  • Try to read card and get read failed
  • Use "Save Partial"
  • Emulate partial dump to reader
  • Get "NR-MAC Saved!"

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse
Copy link
Collaborator Author

bettse commented Dec 21, 2023

cc @ezhang7423

@bettse bettse marked this pull request as ready for review December 21, 2023 03:05
@ezhang7423
Copy link

Affirming that this change worked for me

@bettse
Copy link
Collaborator Author

bettse commented Jan 1, 2024

@skotopes When you have time, can you review this?

@skotopes
Copy link
Contributor

skotopes commented Jan 1, 2024

@bettse yep, I'll merge it later today.

@skotopes skotopes merged commit afe9ef7 into flipperdevices:dev Jan 2, 2024
@skotopes
Copy link
Contributor

skotopes commented Jan 2, 2024

image

is it ok that after doing such thing to the card it gives this?

@bettse
Copy link
Collaborator Author

bettse commented Jan 2, 2024

is it ok that after doing such thing to the card it gives this?

you did the NR-MAC process?

@bettse bettse deleted the picopass_fix_legacy_nr_mac branch January 2, 2024 04:27
@skotopes
Copy link
Contributor

skotopes commented Jan 2, 2024

Yep. then used another flipper to read partial dump, nr-mac was saved.
Then I restored assets and tried to read this card and it gets me this.

PS: Removing picopass folder with nr-mac data restores reading.

@bettse
Copy link
Collaborator Author

bettse commented Jan 2, 2024

Yeah, this is expected. when doing the NR-MAC read we don't know the key (all 00's), but we do read the data. The only time this preempts is when the {nr}_{mac} file exists, which is easy to clean up, as you saw

@bettse
Copy link
Collaborator Author

bettse commented Jan 2, 2024

I'll make a note that perhaps we could put on the screen "Read using NR-MAC" instead of the key

@skotopes
Copy link
Contributor

skotopes commented Jan 2, 2024

ok ok )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants