Skip to content

Picopass config se problem #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 4 commits into from
Dec 20, 2023
Merged

Picopass config se problem #90

skotopes merged 4 commits into from
Dec 20, 2023

Conversation

@bettse
Copy link
Collaborator

@bettse bettse commented Dec 19, 2023 •
edited by skotopes
Loading

What's new

  • Correct config card detection so it doesn't happen for SE cards (read using nr-mac partial read)
  • Have back button go to start menu instead of read retry

Verification

  • This is a bit tricky. You need to find an iClass SE whose SIO coincidentally also matches the config card check

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

bettse
bettse commented Dec 19, 2023
View reviewed changes
@bettse bettse marked this pull request as ready for review December 19, 2023 02:28
skotopes
skotopes previously approved these changes Dec 20, 2023
View reviewed changes
@skotopes skotopes merged commit d1d45d8 into flipperdevices:dev Dec 20, 2023
@bettse bettse deleted the picopass_config_se_problem branch December 20, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

2 more reviewers

@kitsunehunter kitsunehunter kitsunehunter left review comments

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

app:picopass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bettse @skotopes @kitsunehunter @hedger