Skip to content

Picopass: detect config card #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 1 commit into from
Dec 18, 2023
Merged

Picopass: detect config card #87

skotopes merged 1 commit into from
Dec 18, 2023

Conversation

@bettse
Copy link
Collaborator

@bettse bettse commented Dec 17, 2023 •
edited by skotopes
Loading

What's new

  • Show "Config Card" on UI when a config card is scanned (Instead of "Invalid pacs"

Verification

  • Scan a config card
  • See "Config Card" on the UI

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review December 17, 2023 19:57
@bettse bettse added the enhancement New feature or request label Dec 18, 2023
@skotopes skotopes merged commit 8cb09e7 into flipperdevices:dev Dec 18, 2023
@bettse bettse deleted the picopass_config_card branch December 19, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

app:picopass enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bettse @skotopes @hedger