Skip to content

Conversation

@kitsunehunter
Copy link
Contributor

@kitsunehunter kitsunehunter commented Nov 23, 2023

What's new

  • As a end user, I would like to know what specific magic cards are supported when a unsupported credential is scanned by the "check magic tag" option. Instead of just a generic error of "Not magic or unsupported card," the error page will tell the user that the only supported magic cards are Gen1 and Gen4 UMC. Should help reduce confusion between Gen4 UMC (GTU) and Gen4 GDM (USCUID / GDMIC) which is not currently supoorted.

Verification

  • Launch NFC Magic app and scan a unsupported credential. The error page should clearly tell the user that only Gen1 and Gen4 UMC cards are supported with no text overlap / cutoff / word wrap.
  • No additional regression testing is necessary.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes merged commit db08fca into flipperdevices:dev Dec 6, 2023
@kitsunehunter kitsunehunter deleted the specific_magic_cards branch December 7, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:nfc_magic enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants