Skip to content

Conversation

@bettse
Copy link
Collaborator

@bettse bettse commented Jan 27, 2024

What's new

  • Message if card isn't present

#109 (comment)
Screenshot-20240123-193225

Verification

  • Launch picopass->read without a card, see message
  • Present card, see dictionary attack

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review January 29, 2024 04:43
@skotopes
Copy link
Contributor

Not sure if skip button is needed on read start screen:
image

Also after first successful read, reading again will show different message:
image

@bettse
Copy link
Collaborator Author

bettse commented Jan 31, 2024

Good catch! Fixed 👍

@bettse
Copy link
Collaborator Author

bettse commented Feb 2, 2024

this is ready for review again

@skotopes skotopes merged commit f82c44b into flipperdevices:dev Feb 6, 2024
@bettse bettse deleted the picopass_read_ui_improvements branch February 7, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants