Skip to content

Picopass: Create seader directory if needed #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 3 commits into from
Jan 2, 2024
Merged

Picopass: Create seader directory if needed #101

skotopes merged 3 commits into from
Jan 2, 2024

Conversation

@bettse
Copy link
Collaborator

@bettse bettse commented Jan 1, 2024 •
edited by skotopes
Loading

What's new

  • Creates apps_data/seader before saving seader credential

Verification

  • Don't have an apps_data/seader folder
  • Use the readme instructions to read an iClass SE card.
  • Try to save
  • See file saved successfully in apps_data/seader folder (before it was an error screen)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review January 1, 2024 17:52
@skotopes skotopes merged commit 3616b2c into flipperdevices:dev Jan 2, 2024
@bettse bettse deleted the picopass_save_seader_fix branch January 2, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

app:picopass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bettse @skotopes