Skip to content

Conversation

@RebornedBrain
Copy link
Contributor

@RebornedBrain RebornedBrain commented Jan 25, 2024

What's new

  • Previously when we tried to open .nfc file, where we don't support emulation, from browser then app crashes. Now it will show saved menu

Verification

  • Go to browser and open any ,nfc file of type which doesn't support emulation. Result: saved menu will be opened.
  • Go to browser and open any ,nfc file of type which supports emulation. Result: emulation will be started.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

gornekich
gornekich previously approved these changes Jan 30, 2024
@xMasterX
Copy link
Contributor

Hi!
These changes does not fix the issue fully,
Delete button causes crash
Rename button causes exit into main NFC app - incorrect logic

All required fixes are done in attached patch file, apply before merging
Thanks

287239.patch

@xMasterX
Copy link
Contributor

And this patch after first one too
fe05c6.patch

Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more clear if all navigation logic is written in one style. Apply patch
scene_save_success_cleanup.txt

@hedger hedger merged commit cd8e76b into flipperdevices:dev Feb 6, 2024
@hedger hedger added NFC NFC-related UI Affects UI labels Feb 6, 2024
@RebornedBrain RebornedBrain deleted the reborned/open_from_browser branch August 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NFC NFC-related UI Affects UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants