Skip to content

[FL-3755] Rework more info scene for Ultralight cards #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hedger merged 9 commits into from
Feb 6, 2024
Merged

[FL-3755] Rework more info scene for Ultralight cards #3391

hedger merged 9 commits into from
Feb 6, 2024

Conversation

@RebornedBrain
Copy link
Contributor

@RebornedBrain RebornedBrain commented Jan 24, 2024 •
edited by gornekich
Loading

What's new

  • Now we put SceneManagerEvent to event handler, not only custom events. This helps to process different situations in more flexible way
  • Now more_info scene for Ultralight cards is able to show data in both ASCII and Raw bin modes and switch between them by button press

Verification

  • Open Info scene on any Ultralight card and press "More", then the first ASCII view will appear, by pressing "Raw Data" it will switch to another view.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich self-assigned this Jan 24, 2024
gornekich
gornekich previously approved these changes Jan 25, 2024
View reviewed changes
@gornekich
Copy link
Member

gornekich commented Jan 25, 2024

Merge after #3382

hedger
hedger previously approved these changes Feb 6, 2024
View reviewed changes
@hedger hedger self-requested a review February 6, 2024 18:10
@hedger hedger added NFC NFC-related UI Affects UI labels Feb 6, 2024
@hedger hedger merged commit 9d6f514 into flipperdevices:dev Feb 6, 2024
@RebornedBrain RebornedBrain deleted the reborned/scene_info_rework branch August 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedger hedger hedger approved these changes

@gornekich gornekich gornekich left review comments

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

Assignees

@gornekich gornekich

Labels

NFC NFC-related UI Affects UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RebornedBrain @gornekich @hedger