-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[FL-3744] [NFC] Ntag success write freeze when not saved card #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
skotopes
merged 26 commits into
flipperdevices:dev
from
RebornedBrain:reborned/ntag_write
Jan 10, 2024
Merged
[FL-3744] [NFC] Ntag success write freeze when not saved card #3354
skotopes
merged 26 commits into
flipperdevices:dev
from
RebornedBrain:reborned/ntag_write
Jan 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now write is only possible for NTAG21x cards with default password and no AUTHLIM set
…e of check failure and stops poller
Conflicts: applications/main/nfc/scenes/nfc_scene_mf_ultralight_write_fail.c applications/main/nfc/scenes/nfc_scene_mf_ultralight_write_success.c applications/main/nfc/scenes/nfc_scene_mf_ultralight_wrong_card.c
gornekich
approved these changes
Jan 10, 2024
skotopes
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
When we try to write ntag which was read but not saved, write process successes and shows "Success" screen and now by pressing back button we move back to ReadSuccess screen.
Verification
Result: Flipper shows ReadSuccess screen after one button press
Previous: Have to spam back in order to move to previous screen
Checklist (For Reviewer)