Skip to content

Fix MyKey production date parsing #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 3 commits into from
Jan 10, 2024
Merged

Fix MyKey production date parsing #3332

skotopes merged 3 commits into from
Jan 10, 2024

Conversation

@augustozanellato
Copy link
Contributor

@augustozanellato augustozanellato commented Jan 2, 2024 •
edited by gornekich
Loading

What's new

  • Fix swapped day and year in MyKey production date parsing
  • Made production date checks more pedantic reducing possible false positives.

Verification

  • Scan a tag and verify the parser works correctly

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added the NFC NFC-related label Jan 3, 2024
gornekich
gornekich approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skotopes skotopes merged commit 0b15fc3 into flipperdevices:dev Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gornekich gornekich gornekich approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

+1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gornekich gornekich

Labels

NFC NFC-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@augustozanellato @skotopes @gornekich @hedger