Skip to content

Added NFC plugin; parser for WashCity cards. #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 7 commits into from
Dec 28, 2023
Merged

Added NFC plugin; parser for WashCity cards. #3319

skotopes merged 7 commits into from
Dec 28, 2023

Conversation

@yaba
Copy link
Contributor

@yaba yaba commented Dec 26, 2023 •
edited by gornekich
Loading

What's new

  • Added new NFC plugin to read/parse WashCity (MarkItaly) cards.

Verification

  • Added App in application.fam
  • Added new file washcity.c
  • Parser reads serial number and current balance in Euros.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added the NFC NFC-related label Dec 26, 2023
@hedger
Copy link
Member

hedger commented Dec 26, 2023

Could you also provide sample card dumps for testing?

@yaba
Copy link
Contributor Author

yaba commented Dec 26, 2023

Could you also provide sample card dumps for testing?

Sure, allow me a couple of minutes. BTW, seems that I've messed up the file path, it's now fixed.

@hedger
Copy link
Member

hedger commented Dec 26, 2023

Please build the firmware locally and run linters.

@yaba
Copy link
Contributor Author

yaba commented Dec 26, 2023

Please build the firmware locally and run linters.

Done, sorry.

gornekich
gornekich requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!
Please, remove Demo_WC_20E.nfc file from resources and we will merge it. Example dump shouldn't be part of nfc resources.

gornekich
gornekich approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skotopes skotopes merged commit 35e74c0 into flipperdevices:dev Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gornekich gornekich gornekich approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

+1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gornekich gornekich

Labels

NFC NFC-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yaba @hedger @skotopes @gornekich