Skip to content

[FL-3706], [FL-3674] NFC NTAG and ISO14443-3b reading fix #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 3 commits into from
Dec 12, 2023
Merged

[FL-3706], [FL-3674] NFC NTAG and ISO14443-3b reading fix #3285

skotopes merged 3 commits into from
Dec 12, 2023

Conversation

@gornekich
Copy link
Member

@gornekich gornekich commented Dec 12, 2023 •
edited by skotopes
Loading

What's new

  • Fix reading NTAG cards with default password by resetting field after reading tearing flag
  • Fix ISO14443-3b poller. Now poller checks only 7 bits CID in ATTRIB response since last bit is RFU

Verification

  • Read NTAGs with default password, no locking configuration and unset AUTHLIM. Flipper should try default password and fully read tag
  • Read Iso14443-3b tags which respond to ATTRIB command with MSB set in CID. Flipper should complete anticollision successfully.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Compiled f7 firmware for commit 1fff8306:

This was referenced Dec 12, 2023
Closed
Closed
@skotopes skotopes added NFC NFC-related Bug labels Dec 12, 2023
@skotopes skotopes merged commit 155e4e9 into dev Dec 12, 2023
@skotopes skotopes deleted the gornek/3706_ntag_read_fix branch December 12, 2023 15:24
@WillyJL WillyJL mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug NFC NFC-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gornekich @skotopes