Skip to content

[FL-3666] NFC API improvements #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 29 commits into from
Nov 15, 2023
Merged

[FL-3666] NFC API improvements #3214

skotopes merged 29 commits into from
Nov 15, 2023

Conversation

@gornekich
Copy link
Member

@gornekich gornekich commented Nov 13, 2023 •
edited by skotopes
Loading

What's new

  • Add nfc_poller_start_ex API to nfc poller to help creating custom state machines for protocol pollers.
  • Massive renaming.
  • Expose st25r3916 registers API.
  • Add pollers functions to public API
  • Add documentation

Verification

  • NFC application works as before

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich marked this pull request as draft November 13, 2023 20:13
@github-actions
Copy link

github-actions bot commented Nov 13, 2023

PVS-Studio report for commit 202d0eaf:

@github-actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

Compiled f7 firmware for commit 8f4839e7:

@gornekich gornekich marked this pull request as ready for review November 14, 2023 20:48
@gornekich gornekich added the NFC NFC-related label Nov 14, 2023
@gornekich gornekich mentioned this pull request Nov 14, 2023
Closed
3 tasks
@skotopes skotopes merged commit c00776c into dev Nov 15, 2023
@skotopes skotopes deleted the gornek/3666_nfc_api_improvements branch November 15, 2023 08:32
@gornekich gornekich mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NFC NFC-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gornekich @skotopes