Skip to content

[FL-3629] fbt: SD card resource handling speedup #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hedger merged 3 commits into from
Oct 31, 2023
Merged

[FL-3629] fbt: SD card resource handling speedup #3178

hedger merged 3 commits into from
Oct 31, 2023

Conversation

@hedger
Copy link
Member

@hedger hedger commented Oct 31, 2023 •
edited by skotopes
Loading

What's new

  • fbt: reduced size of resources dependency graphs, resulting in faster build task evaluation
  • lib: flipper_app: fixed error message & error handling for plugins

Verification

  • resources processing and building (with fbt resources) should be considerably faster than on dev, while having same output structure and contents

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Compiled f7 firmware for commit 7600565d:

@hedger hedger marked this pull request as ready for review October 31, 2023 09:39
skotopes
skotopes previously approved these changes Oct 31, 2023
View reviewed changes
@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Oct 31, 2023
@hedger hedger changed the title [FL-3629] fbt: reduced size of resources dependency graphs [FL-3629] fbt: SD card resource handling speedup Oct 31, 2023
@hedger hedger merged commit bbe68d6 into dev Oct 31, 2023
@hedger hedger deleted the hedger/3629-resources_speedup branch October 31, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build System & Scripts fbt, scripts and toolchain-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hedger @skotopes