Skip to content

fbt: Fix tar uid overflow when packaging #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hedger merged 2 commits into from
May 22, 2023
Merged

fbt: Fix tar uid overflow when packaging #2689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cc76aa
fbt: Fix tar uid overflow when packaging
GMMan May 22, 2023
1e381ce
Fix trailing spaces
GMMan May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/sconsdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,13 @@ def bundle_update_package(self):
self.note_dist_component(
"update", "tgz", self.get_dist_path(bundle_tgz)
)
tar.add(bundle_dir, arcname=bundle_dir_name)

# Strip uid and gid in case of overflow
def tar_filter(tarinfo):
tarinfo.uid = tarinfo.gid = 0
return tarinfo

tar.add(bundle_dir, arcname=bundle_dir_name, filter=tar_filter)
return bundle_result


Expand Down