Skip to content

fix width of submenu items on Vertical orientation #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skotopes merged 5 commits into from
Jun 30, 2023
Merged

fix width of submenu items on Vertical orientation #2306

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b28162
fix width of submenu items on vertical view
gebeto Jan 15, 2023
38b94b9
Merge branch 'dev' into submenu-vertical-fix
skotopes Jan 17, 2023
6d6422a
Merge branch 'dev' into submenu-vertical-fix
skotopes Jun 30, 2023
c5789b1
Gui: slightly better canvas width handling in submenu
skotopes Jun 30, 2023
cec79d4
Gui: remove unused include
skotopes Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion applications/services/gui/modules/submenu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "submenu.h"
#include <gui/canvas_i.h>

#include <m-array.h>
#include <gui/elements.h>
Expand Down Expand Up @@ -63,7 +64,12 @@ static void submenu_view_draw_callback(Canvas* canvas, void* _model) {
SubmenuModel* model = _model;

const uint8_t item_height = 16;
const uint8_t item_width = 123;
uint8_t item_width = 123;

if(canvas->orientation == CanvasOrientationVertical ||
canvas->orientation == CanvasOrientationVerticalFlip) {
item_width = 60;
}

canvas_clear(canvas);

Expand Down