SD info: Add dynamic units and free % #1634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotopes
suggested changes
Aug 22, 2022
| dialog_ex, "Try to reinsert\nor format SD\ncard.", 3, 19, AlignLeft, AlignTop); | ||
| dialog_ex_set_center_button_text(dialog_ex, "Ok"); | ||
| } else { | ||
| char unit_kb[] = "KB"; |
Contributor
There was a problem hiding this comment.
No need to put it in ram, use const.
| char unit_mb[] = "MB"; | ||
| char unit_gb[] = "GB"; | ||
|
|
||
| double sd_total_val = (double)sd_info.kb_total; |
Contributor
There was a problem hiding this comment.
Using float point math here is kinda overkill.
Contributor
There was a problem hiding this comment.
Especially using double. Float should be more than enough, use cast at the last moment when passing it to string_printf.
| double sd_free_val = (double)sd_info.kb_free; | ||
| char* sd_free_unit = unit_kb; | ||
|
|
||
| if(sd_total_val > 1024) { |
Contributor
There was a problem hiding this comment.
Better solution will be to implement formatting function that takes double* and const char**
Contributor
|
@non-bin do you plan to continue work on this PR? |
Author
|
Yeah I will |
Contributor
|
Feel free to reopen when it will be ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)