[FL-2529][FL-1628] New LF-RFID subsystem #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appear to be extended HID Proximity keys that are longer than 37 bits that fit into a 44-bit payload (88 raw bits after Manchester encoding, plus the 0x1D preamble for a total of 96 raw bits). These keys don't start with 0b100111 like some extended HID keys supposedly do.
One way to detect these keys is to see if any of the first six bits in the 44-bit payload is a 1. If so, the key is longer than 37 bits. This means the longest key that can fit into a 44-bit payload is 43 bits (the first bit is a 1, followed by 43 key bits).
Also fixed a bug rendering the first nibble of a HID key in `protocol_hid_generic_string_cat_protocol_bits`.
Tested by running `raw_analyze` on known RFID captures:
```
rfid raw_analyze /ext/hid40.raw
...
Frequency: 125000.000000
Duty Cycle: 0.500000
Warns: 0
Pulse sum: 25415
Duration sum: 40179
Average: 0.632544
Protocol: HIDProx [1X XX XX XX XX X0]
Description:
40-bit HID Proximity
Data: XXXXXXXXXX
```
```
rfid raw_analyze /ext/hid36.raw
...
Frequency: 125000.000000
Duty Cycle: 0.500000
Warns: 0
Pulse sum: 28080
Duration sum: 41618
Average: 0.674708
Protocol: HIDProx [03 XX XX XX XX X0]
Description:
36-bit HID Proximity
Data: XXXXXXXXX
```
|
PVS-Studio report for commit |
|
Unfortunately not working on my pets. They have ISO Transponder Microchip 2.12*12mm, think this one - https://www.animal-microchip.com/sale-9568205-professional-iso-transponder-microchip-2-12-12mm-for-animals-identification.html
But with your branch there is no reaction at all. On version 0.64.3, I can see the LED indication that the chip is responding Upd. My mistake, I had to choose Extra Actions in the menu. So, now I see that LED is blinking green(or yellow, not sure), but still not reading the microchip Upd2. Found the spot:) Thank you! It is works |
skotopes
approved these changes
Aug 23, 2022
hedger
approved these changes
Aug 23, 2022
skotopes
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
New protocols:
Verification
Checklist (For Reviewer)