Skip to content

[FL-2728] Fix Null Pointer Dereference errors in IR #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 3 commits into from
Aug 12, 2022
Merged

[FL-2728] Fix Null Pointer Dereference errors in IR #1583

skotopes merged 3 commits into from
Aug 12, 2022

Conversation

@gsurkov
Copy link
Member

@gsurkov gsurkov commented Aug 11, 2022 •
edited by skotopes
Loading

What's new

  • Fixed Null pointer dereference errors in Infrared App
  • Cleaned up code

Verification

  1. Go to Infrared -> Learn New Remote
  2. Add several new buttons by repeatedly pressing the + button. Use a RC5(X) remote.
  3. No crashes should occur.
  4. Use the IR App as usual. No crashes should occur.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Aug 11, 2022 •
edited
Loading

Compiled firmware for commit 9b900958:

@skotopes skotopes merged commit 1655366 into dev Aug 12, 2022
@skotopes skotopes deleted the gsurkov/2728_ir_worker_null_pointer branch August 12, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsurkov @skotopes