Skip to content

Improved PR build comment #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 5 commits into from
Jul 3, 2022
Merged

Improved PR build comment #1348

skotopes merged 5 commits into from
Jul 3, 2022

Conversation

@djsime1
Copy link
Contributor

@djsime1 djsime1 commented Jun 27, 2022 •
edited by skotopes
Loading

What's new

  • Bot comment on PR's include links to update package, DFU file, and web updater.

Verification

  • Merge and trigger GH Actions on a PR.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Contributor

skotopes commented Jun 27, 2022

Hi. Thanks for PR.

There is one small issue: comment is not going to be updated because of

flipperzero-firmware/.github/workflows/build.yml

Line 140 in 6d38740

- name: 'Find Previous Comment'

@djsime1
Copy link
Contributor Author

djsime1 commented Jun 27, 2022

Forgot about that, will fix.

@skotopes skotopes merged commit 09ec383 into flipperdevices:dev Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djsime1 @skotopes