nfc: DESFire fixes #1334
Merged
nfc: DESFire fixes #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2022 04:07
Some cards are configured to refuse to provide key settings, but still provide other info. For example, Ubiquiti UniFi Protect access cards won't list keys or applications, but will still answer GET_FREE_MEMORY.
kevinwallace
requested review from
DrZlo13,
gornekich,
hedger and
skotopes
as code owners
Member
|
Hello @kevinwallace ! Could you please fix it in this PR? |
gornekich
requested changes
Jun 21, 2022
Member
gornekich
left a comment
gornekich
left a comment
There was a problem hiding this comment.
Please, add support for loading cards with 0 App count
Contributor
Author
|
Oops, sorry, I should have caught that! Thanks for the stack trace. Fixed in 1464afd, and verified saving and loading with the card shown in the photo above. (Also, noted that 0-byte mallocs are unsupported, will avoid those in the future) |
skotopes
approved these changes
Jun 21, 2022
hedger
pushed a commit
that referenced
this pull request
Jun 21, 2022
* nfc: don't give up on reading DESFire card if GET_KEY_SETTINGS fails Some cards are configured to refuse to provide key settings, but still provide other info. For example, Ubiquiti UniFi Protect access cards won't list keys or applications, but will still answer GET_FREE_MEMORY. * nfc: don't show error when saving DESFire card with no applications * nfc: fix DESFire load with 0 applications or no PICC key settings Co-authored-by: Kevin Wallace <[email protected]> Co-authored-by: gornekich <[email protected]> Co-authored-by: あく <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
FURI_LOG_Win a loop)A "UniFi Access" card can be used to test both of the above scenarios.
Checklist (For Reviewer)