Skip to content

Nfc: async pcap worker #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DrZlo13 merged 6 commits into from
Jun 14, 2022
Merged

Nfc: async pcap worker #1315

DrZlo13 merged 6 commits into from
Jun 14, 2022

Conversation

@skotopes
Copy link
Contributor

@skotopes skotopes commented Jun 13, 2022 •
edited by DrZlo13
Loading

What's new

  • Nfc: async pcap worker

Verification

  • Compile and upload
  • Test NFC with debug on
  • Check resulting debug.pcap file in nfc folder

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes marked this pull request as draft June 13, 2022 09:33
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

Install with web updater.

gornekich
gornekich previously approved these changes Jun 13, 2022
View reviewed changes
@gornekich gornekich self-requested a review June 13, 2022 12:30
gornekich
gornekich previously approved these changes Jun 13, 2022
View reviewed changes
@djsime1
Copy link
Contributor

djsime1 commented Jun 13, 2022

👍 Captured and inspected reading an Ultralight tag. I'll try reading a MF Classic once I find where my card is hiding.

@flipperdevices flipperdevices deleted a comment from github-actions bot Jun 14, 2022
@flipperdevices flipperdevices deleted a comment from github-actions bot Jun 14, 2022
@skotopes skotopes marked this pull request as ready for review June 14, 2022 00:40
@djsime1
Copy link
Contributor

djsime1 commented Jun 14, 2022

MF Classic read captures fine as well.

@DrZlo13 DrZlo13 merged commit b2132b2 into dev Jun 14, 2022
@DrZlo13 DrZlo13 deleted the aku/nfc_async_pcap branch June 14, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 DrZlo13 approved these changes

@gornekich gornekich gornekich left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skotopes @djsime1 @DrZlo13 @gornekich