Add svd_solver to phase 1 sorter parameters
#53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50, we discussed ways to speed up the
compute_pca_featuresfunction in phase 1, which was the bottleneck for applying mountainsort5 my data.When experimenting, I found that using the
covariance_eighalgorithm for decomposition (https://scikit-learn.org/stable/modules/generated/sklearn.decomposition.PCA.html) sped things up a lot! This PR allows users to specify thephase_1_svd_solverparameter, but keeps the current default.I don't have any solid benchmarks for saying that
covariance_eighworks fine - but it works fine for my data!Note that this does not get passed to
isosplit6_subdivision_methodbecause it takes a smaller subset of data, and the default method runs quickly.If something like this gets merged, I can update the spikeinterface side too :)