update CI workflow to avoid deprecation warnings and build errors #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample run from my fork. |
Bump MSRV to allow deps that use newer features to be selected.
davidblewett
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking a look at the repo and noticed that there are a lot of warnings regarding deprecated Node and Action commands regarding the CI workflow.
Part of resolving this is addressing
actions-rs/toolchain, which is no longer maintained from my understanding.dtolnay/rust-toolchainis actively maintained and works well from my experience, so I think switching over should be fine and resolves the issues. The rest is fixed by just updatingcheckouttov3.This also updates the
rust_versionto 1.54.0, since this change means that 1.53.0 will no longer build. Not sure if this should be reflected in the MSRV.