Fix make compile_commands.json and add to vscode project settings
#96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2022 14:53
…nds.json file Because no specific shell was set in the Makefile it defaults to /bin/sh which has a built-in version of echo that does not accept the -n option and instead will write -n to stdout. Setting the shell to /bin/bash means we will use bash and bashs's built-n echo which does support the -n option, which means we will start generating a valid JSON file for compile_commands.json
elliottt
approved these changes
Jun 9, 2022
Contributor
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
Awesome, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because no specific shell was set in the Makefile it defaults to /bin/sh which has a built-in version of echo that does not accept the -n option and instead will write -n to stdout.
Setting the shell to /bin/bash means we will use bash and bashs's built-n echo which does support the -n option, which means we will start generating a valid JSON file for compile_commands.json