Change error message which is given when constructing a Response instance with a body and a null body status #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
changed the title
tschneidereit
approved these changes
Mar 24, 2022
Contributor
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Oops, great catch—thank you! <3
…status that is 204, 205, or 304. previously this error message said "Request constructor", which was misleading as this error is within the Response constructor. I've used the same error message text as Firefox does. We could modify the error message some more to mention which status codes are 'null body' statuses, as a null body status is a status that is 101, 204, 205, or 304, and the user reading the error message may not know what is meant by `null body status`.
Contributor
Author
|
@tschneidereit I rebased this and now it all passes 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously this error message said "Request constructor", which was misleading as this error is within the Response constructor.
I've used the same error message text as Firefox does.
We could modify the error message some more to mention which status codes are 'null body' statuses, as a null body status is a status that is 101, 204, 205, or 304, and the user reading the error message may not know what is meant by
null body status.