Skip to content

Conversation

@elliottt
Copy link
Contributor

In order to make the compute-sdk-test action reusable for other sdks, and to wrangle its current complexity, this PR adds a class to track configuration information and plumbs it through the tests. The next step will be to break up the test running logic in main.js so that it's possible to run one test at a time.

@elliottt elliottt marked this pull request as ready for review June 29, 2022 00:20
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, my inclination would be to take this in a different direction, namely:

  • put as little logic in the GitHub Action as possible
  • make each test responsible for all of its own setup; ideally each test would just be an arbitrary executable script, whether that's JS or shell or whatever's convenient
  • factor out all the common stuff into importable or sourceable libraries and let the tests invoke whichever parts they need

On the other hand, I think this is an improvement over what's already there, so, 👍

@elliottt elliottt merged commit f49a03c into main Jun 29, 2022
@elliottt elliottt deleted the trevor/refactor-test-running branch June 29, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants