Add a script to run all integration tests #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/run-all-tests-script
branch
from
5db76b2 to
2e5c56d
Compare
elliottt
force-pushed
the
trevor/run-all-tests-script
branch
from
2e5c56d to
e8d0bf5
Compare
jameysharp
approved these changes
Jun 28, 2022
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
I suppose you could cd "$(dirname "${BASH_SOURCE[0]}")"/../.. at the beginning of the script and then use relative paths rather than using ${root} anywhere, but it doesn't matter. This seems fine, and having a script to easily run these tests locally is great. I also appreciate that you check for so many things that might be a surprise for a new contributor.
Contributor
Author
|
I think your suggestion to change directory at the beginning of the script makes it more clear, so I've made that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to run the integration tests locally by adding a script to wrap running the github action.