Allow URL to be used as a base class to extend from within application javascript #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
suggested changes
Jun 22, 2022
Contributor
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
Looks good, just one question about checking an allocated object.
Comment on lines
6811
to
6815
Contributor
There was a problem hiding this comment.
Should this check that urlInstance is not nullptr?
JakeChampion
commented
Jun 22, 2022
JakeChampion
force-pushed
the
jake/extend-from-urlsearchparams
branch
from
95473a3 to
9a14faa
Compare
elliottt
approved these changes
Jun 22, 2022
JakeChampion
force-pushed
the
jake/extend-from-url
branch
from
2ba6e86 to
396d29d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is part of the solution for #113
This pull-request changes our URL implementation to use JS_NewObjectForConstructor when the construction has come from the applications' JavaScript, which assigns the correct prototype to the instance being constructed (taking into account extends in JavaScript)
I've also added a test which confirms that the correct prototype has been assigned when extending from URL, the test is written in a way that makes it simpler to add the same test for any other builtin classes