Cache more in CI #112
Merged
Cache more in CI #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameysharp
force-pushed
the
jsharp/cache-more
branch
3 times, most recently
from
f067021 to
22ce570
Compare
I'm also only copying js-compute-runtime.wasm into the job's uploaded artifacts, not any temporary files generated during the build.
...and also rely on CI-provided versions of rustup, even on Mac.
The idea here is to use rustup and the Rust toolchain configured in the outer container, while using the C toolchain from the inner Centos container.
If `main` is uncached, then each new pull request starts with an empty cache. But ignore the build cache on tagged releases. This is possibly excessive caution. It ensures that artifacts published with a release of this SDK aren't corrupted by broken caches.
jameysharp
force-pushed
the
jsharp/cache-more
branch
from
48caa3c to
b8fbe99
Compare
elliottt
approved these changes
Jun 16, 2022
Contributor
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
This looks great to me, thanks for improving build times!
| make -f ../c-dependencies/js-compute-runtime/Makefile | ||
| rm *.{d,o} | ||
| cd .. | ||
| run: make -C c-dependencies/js-compute-runtime DESTDIR=$PWD install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are more experiments in caching various steps that run in GitHub Actions.