Skip to content

Conversation

@jameysharp
Copy link
Contributor

@jameysharp jameysharp commented Jun 15, 2022

Now that we're caching Rust crate dependencies, the slowest part of the Linux platform build step is setting up the Centos image. This branch is an attempt to make that cachable too.

@jameysharp jameysharp force-pushed the jsharp/faster-docker branch 4 times, most recently from b46c715 to b526e6c Compare June 16, 2022 01:29
@jameysharp jameysharp changed the title Only invoke docker exec once during build setup Speed up Docker container preparation Jun 16, 2022
@jameysharp jameysharp marked this pull request as draft June 16, 2022 15:14
@jameysharp jameysharp force-pushed the jsharp/faster-docker branch 3 times, most recently from fd3ce02 to 852eaa4 Compare June 16, 2022 15:43
@jameysharp jameysharp force-pushed the jsharp/faster-docker branch 3 times, most recently from b088431 to 7161c4c Compare June 16, 2022 16:56
@jameysharp jameysharp marked this pull request as ready for review June 16, 2022 16:58
@jameysharp jameysharp requested a review from elliottt June 16, 2022 16:58
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Comment on lines +5 to +6
using: "composite"
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this change!

@jameysharp jameysharp merged commit 5bcdde7 into main Jun 16, 2022
@jameysharp jameysharp deleted the jsharp/faster-docker branch June 16, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants