fix: Handle cross-volume renames of intermediate files #1264
+38
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmony7
changed the title
kpfleming
approved these changes
Dec 19, 2025
Contributor
kpfleming
left a comment
kpfleming
left a comment
There was a problem hiding this comment.
Confirmed with a local build that this resolves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the problem such as the following that occurs during the build among intermediate files when the OS temp directory is not on the same volume as the working directory.
The problem was due to the use of
rename()to move a temporary file to the output directory, which does not work across volumes.The proposed fix adds a
moveFile()function that works by first attempting therename(), and upon receivingEXDEV, falling back tocopyFile()+unlink().I've also renamed the
isFile.tsfile tofiles.ts, turning it into the file that contains file-related utilities.