Skip to content

Conversation

@itsrainy
Copy link
Contributor

@itsrainy itsrainy commented Jul 18, 2022

These are the integration tests from the compute-tinygo repo with a few changes:

  1. I've removed the tests that run on C@E for now and kept the Viceroy tests. The C@E tests will be helpful in the future, but we'll need to write them in a way that they aren't clobbering each other if two people/actions/PRs are running the tests at the same time.
  2. Removed references to un-needed service IDs and C@E endpoints from the test config
  3. Moved the github action from the compute-sdk-ci-github-action directly into this repo, similar to how we've done for the js-compute-runtime repository

Since the action has been moved directly to this repo, a github token is no longer needed to run the integration tests locally, so I've updated the _run_integration_tests.sh script accordingly.

@itsrainy itsrainy requested a review from dgryski July 18, 2022 15:42
@itsrainy itsrainy changed the title Add integration test fixtures and github action Add integration test fixtures and compute-sdk-test github action Jul 18, 2022
Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but otherwise looks great.

@itsrainy itsrainy requested a review from dgryski July 19, 2022 16:04
uses: actions/checkout@v2
- uses: ./.github/actions/bootstrap-integration-test
- name: Check our bootstrap dependencies were installed correctly, and in our $PATH
- name: Check our bootstrap dependencies wre installed correctly, and in our $PATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted an e

Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@itsrainy itsrainy merged commit 6be2bd9 into main Jul 20, 2022
@itsrainy itsrainy deleted the rainy/viceroy-tests branch July 20, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants