-
Notifications
You must be signed in to change notification settings - Fork 10
Add integration test fixtures and compute-sdk-test github action #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgryski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but otherwise looks great.
| uses: actions/checkout@v2 | ||
| - uses: ./.github/actions/bootstrap-integration-test | ||
| - name: Check our bootstrap dependencies were installed correctly, and in our $PATH | ||
| - name: Check our bootstrap dependencies wre installed correctly, and in our $PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted an e
dgryski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
These are the integration tests from the
compute-tinygorepo with a few changes:compute-sdk-ci-github-actiondirectly into this repo, similar to how we've done for the js-compute-runtime repositorySince the action has been moved directly to this repo, a github token is no longer needed to run the integration tests locally, so I've updated the
_run_integration_tests.shscript accordingly.