feat: use node's built-in globbing tool #549
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We CANNOT move to node's built-in globbing mechanism, this PR is to show this, and can potentially be used later to build upon.
The
node:fs.globfunction does not traverse symbolic links that point to directories. It does not expose an option to enable traversal of directory symlinks, unlike the behavior found in the existing globbing libraries.I have raised a feature request with the node team for this: nodejs/node#61033
Relevant node globbing file: https://github.com/nodejs/node/blob/main/lib/internal/fs/glob.js
Failing tests:
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct