Skip to content

Conversation

@jbrough
Copy link

@jbrough jbrough commented Sep 8, 2025

Please anyone feel free to help with this :)

tested encoding on OSX and decoding on Linux AMD:

% of N second chunks decoded and playable without errors (Binary search failed, end of stream etc).

encodec vs PR branch

1 second: 90% vs 98%
10 second: 60% vs 90%
30 second: 14% vs 85%
60 second: 0% vs 75%

This is a bit skewed as at 60 secs my test audio had only 4 chunks and the PR branch is failing on a particular region of audio (is it related to dynamics?). So it's probably much better than 75%.

Also, I should have read the comments -

        roundoff (float): will round the pdf up to that level to remove difference coming
        from e.g. evaluating the Language Model on different architectures.

but having tried it Im not sure that works.

@meta-cla
Copy link

meta-cla bot commented Sep 8, 2025

Hi @jbrough!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@meta-cla
Copy link

meta-cla bot commented Sep 9, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@jbrough jbrough changed the title WIP (Please collab): Deterministic Entropy Coding Cross-Architecture [WIP]: Deterministic Entropy Coding Cross-Architecture Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant