-
Notifications
You must be signed in to change notification settings - Fork 48.8k
[new] [react-is] add typeOfElementType
, extracted from typeOf
#15349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @gaearon this would be a nice simplification to make in enzyme :-) |
1387e2d
to
bb380e4
Compare
ping - just rebased this. any thoughts from react collabs? |
No significant bundle size changes to report. Generated by 🚫 dangerJS |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
This isn't stale, it's just been ignored by collaborators. (Please don't use stalebots, they're incredibly user-hostile) |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
eternally relevant. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump redux |
Any update on this one? If I'm not missing anything, having this functionality would be very useful for hocs that forward refs to wrapped components. |
@gaearon @sebmarkbage 🙏 🙏 🙏 🙏 🙏 🙏 🙏 |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
eternabump |
um, what happened here? please reopen this. |
Apologies for closing — we've accidentally pushed a master branch to the repo (due to an old fork), then deleted it, and this lead to a bunch of PRs getting auto-closed. That said, I don't think we'd want to expand the surface of |
By extracting this functionality, I'll be able to simplify the logic in enzyme here by comparing directly to the type rather than needing to make a fake element.