-
Notifications
You must be signed in to change notification settings - Fork 48.8k
Warn when "false" or "true" is the value of a boolean DOM prop #13372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1447508
b8f83cd
f3248f2
f70a0eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2506,6 +2506,34 @@ describe('ReactDOMComponent', () => { | |
}); | ||
}); | ||
|
||
describe('Boolean attributes', function() { | ||
it('warns on the ambiguous string value "false"', function() { | ||
let el; | ||
expect(() => { | ||
el = ReactTestUtils.renderIntoDocument(<div hidden="false" />); | ||
}).toWarnDev( | ||
'Received the string `false` for the boolean attribute `hidden`. ' + | ||
'The browser will interpret it as a truthy value. ' + | ||
'Did you mean hidden={false}?', | ||
); | ||
|
||
expect(el.getAttribute('hidden')).toBe(''); | ||
}); | ||
|
||
it('warns on the potentially-ambiguous string value "true"', function() { | ||
let el; | ||
expect(() => { | ||
el = ReactTestUtils.renderIntoDocument(<div hidden="true" />); | ||
}).toWarnDev( | ||
'Received the string `true` for the boolean attribute `hidden`. ' + | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add |
||
'Although this works, it will not work as expected if you pass the string "false". ' + | ||
'Did you mean hidden={true}?', | ||
); | ||
|
||
expect(el.getAttribute('hidden')).toBe(''); | ||
}); | ||
}); | ||
|
||
describe('Hyphenated SVG elements', function() { | ||
it('the font-face element is not a custom element', function() { | ||
let el; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -444,7 +444,7 @@ describe('ReactDOMInput', () => { | |
|
||
it('should take `defaultValue` when changing to uncontrolled input', () => { | ||
const node = ReactDOM.render( | ||
<input type="text" value="0" readOnly="true" />, | ||
<input type="text" value="0" readOnly={true} />, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test was broken by adding the warning on |
||
container, | ||
); | ||
expect(node.value).toBe('0'); | ||
|
Uh oh!
There was an error while loading. Please reload this page.