Skip to content

Removing unnecessary spread plugin proposal since it's in @babel@7 #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Removing unnecessary spread plugin proposal since it's in @babel@7 #5331

wants to merge 4 commits into from

Conversation

assuncaocharles
Copy link

Related to the issue #5310 that's a correct observation since "@babel/core": "7.1.0" is already a dependency make this plugin unnecessary.

https://babeljs.io/blog/2018/08/27/7.0.0#tc39-proposals-https-githubcom-tc39-proposals-support

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@assuncaocharles
Copy link
Author

I see that trevis is failing to run e2e-installs.sh, what locally runs just fine. Any idea what should be done here?

@Timer
Copy link
Contributor

Timer commented Oct 6, 2018

We should probably add a E2E test with the old regression test to make sure this doesn't break again.

@Timer
Copy link
Contributor

Timer commented Oct 8, 2018

This behavior still seems buggy, see unreleased patch to fix these interactions: babel/babel#8793

@ianschmitz
Copy link
Contributor

This behavior still seems buggy, see unreleased patch to fix these interactions: babel/babel#8793

Looks like this was released as part of v7.1.3

@Timer
Copy link
Contributor

Timer commented Nov 4, 2018

Unfortunately, I still don't trust that this works correctly. There's zero harm in including this plugin to be safe, so let's leave it for now.

Thanks for your contribution!

@Timer Timer closed this Nov 4, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants