Skip to content

Test class properties #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 1, 2018
Merged

Test class properties #5183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
946d1ad
Test flow types are stripped before class properties are transformed
Timer Sep 30, 2018
5b5324d
Do not search multiple levels deep
Timer Sep 30, 2018
c3b85eb
Revert "Do not search multiple levels deep"
Timer Sep 30, 2018
5746167
Add missing file for test script to boot
Timer Sep 30, 2018
8d6135f
Make sure src and node modules are ignored
Timer Sep 30, 2018
5480a1f
Fix error
Timer Sep 30, 2018
d36fe36
derp
Timer Sep 30, 2018
df0dd75
fix test
Timer Sep 30, 2018
1603351
Drop unneeded check
Timer Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions fixtures/smoke/issue-5176-flow-class-properties/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
const { bootstrap, isSuccessfulTest } = require('../../utils');
beforeEach(async () => {
await bootstrap({ directory: global.testDirectory, template: __dirname });
});

describe('issue #5176 (flow class properties interaction)', () => {
it('passes tests', async () => {
await isSuccessfulTest({
directory: global.testDirectory,
jestEnvironment: 'node',
});
});
});
1 change: 1 addition & 0 deletions fixtures/smoke/issue-5176-flow-class-properties/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
9 changes: 9 additions & 0 deletions fixtures/smoke/issue-5176-flow-class-properties/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>React App</title>
</head>
<body>
<div id="root"></div>
</body>
</html>
11 changes: 11 additions & 0 deletions fixtures/smoke/issue-5176-flow-class-properties/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
class App {
constructor() {
this.foo = this.foo.bind(this);
}
foo: void => void;
foo() {
return 'bar';
}
}

export default App;
6 changes: 6 additions & 0 deletions fixtures/smoke/issue-5176-flow-class-properties/src/App.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import App from './App';

it('creates instance without', () => {
const app = new App();
expect(app.foo()).toBe('bar');
});
1 change: 1 addition & 0 deletions fixtures/smoke/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module.exports = {
testEnvironment: 'node',
testMatch: ['**/*.test.js'],
testPathIgnorePatterns: ['/src/', 'node_modules'],
setupTestFrameworkScriptFile: './setupSmokeTests.js',
};
14 changes: 13 additions & 1 deletion fixtures/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ async function bootstrap({ directory, template }) {
);
if (shouldInstallScripts) {
const packageJson = fs.readJsonSync(path.join(directory, 'package.json'));
packageJson.dependencies = Object.assign(packageJson.dependencies, {
packageJson.dependencies = Object.assign({}, packageJson.dependencies, {
'react-scripts': 'latest',
});
fs.writeJsonSync(path.join(directory, 'package.json'), packageJson);
Expand Down Expand Up @@ -67,6 +67,17 @@ async function isSuccessfulProduction({ directory }) {
}
}

async function isSuccessfulTest({ directory, jestEnvironment = 'jsdom' }) {
await execa(
'./node_modules/.bin/react-scripts',
['test', '--env', jestEnvironment, '--ci'],
{
cwd: directory,
env: { CI: 'true' },
}
);
}

async function getOutputDevelopment({ directory, env = {} }) {
try {
const { stdout, stderr } = await execa(
Expand Down Expand Up @@ -128,6 +139,7 @@ module.exports = {
bootstrap,
isSuccessfulDevelopment,
isSuccessfulProduction,
isSuccessfulTest,
getOutputDevelopment,
getOutputProduction,
};