Skip to content

Revert "run npm 5.4.0 in CI (#3026)" #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Revert "run npm 5.4.0 in CI (#3026)" #3107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tasks/e2e-installs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ fi

if hash npm 2>/dev/null
then
# npm 5.0-5.4.0 is too buggy
# npm 5 is too buggy right now
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^5.4.1
npm i -g npm@^4.x
fi;
npm cache clean --force || npm cache verify
npm cache clean || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
Expand Down
6 changes: 3 additions & 3 deletions tasks/e2e-kitchensink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ fi

if hash npm 2>/dev/null
then
# npm 5.0-5.4.0 is too buggy
# npm 5 is too buggy right now
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^5.4.1
npm i -g npm@^4.x
fi;
npm cache clean --force || npm cache verify
npm cache clean || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
Expand Down
6 changes: 3 additions & 3 deletions tasks/e2e-simple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ fi

if hash npm 2>/dev/null
then
# npm 5.0-5.4.0 is too buggy
# npm 5 is too buggy right now
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^5.4.1
npm i -g npm@^4.x
fi;
npm cache clean --force || npm cache verify
npm cache clean || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
Expand Down