refactor: move generateRound = 0 to buildEnd
#390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since the `buildEnd` hook exists nowadays, we can just reset it there, right before `generateBundle` is called for each output and increments it per output - also modify the comment to account for this change and the fact that `buildEnd` exists and is used nowadays
agilgur5
added
kind: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Put
generateRound = 0inbuildEndinstead oftransformbuildEndrefactor in fix: type-checkincluded files missed bytransform(type-only files) #345Details
buildEndhook exists nowadays, we can just resetgenerateRoundthere, right beforegenerateBundleis called for each output and increments it per outputbuildEndexists and is used nowadaysReview Notes
Note that
generateRoundis literally only used for logging purposes now, since thebuildEndrefactor made it otherwise unneeded for its original purpose of not duplicating type-check errors between different outputs.Could totally remove it as well 🤷