Skip to content

Conversation

@agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented May 3, 2022

Summary

Replaces normalize.ts with normalizePath from @rollup/pluginutils

Description

  • this was introduced in v4.1.0 of @rollup/pluginutils in feat(pluginutils): normalizePath rollup/plugins#550

    • we're currently on ^4.1.2 for reference
  • this is the same as the code in normalize.ts but it uses constants from Node and is used by multiple Rollup plugins, so just helps with standardization

    • also less code and types to ship in the bundle!
  • removed the dist files for normalize as well, but didn't do a build in this commit as those are usually done in separate commits

- this was introduced in v4.1.0 of @rollup/pluginutils:
  https://github.com/rollup/plugins/blob/master/packages/pluginutils/CHANGELOG.md#v410

- this is the same as the code in `normalize.ts` but it uses constants
  from Node and is used by multiple Rollup plugins, so just helps with
  standardization
  - also less code and types to ship in the bundle!

- removed the dist files for `normalize` as well, but didn't do a build
  in this commit as those are usually done in separate commits
@agilgur5 agilgur5 added the scope: dependencies Issues or PRs about updating a dependency label May 3, 2022
@ezolenko ezolenko merged commit 895431d into ezolenko:master May 4, 2022
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label May 26, 2022
@agilgur5 agilgur5 deleted the deps-use-normalizePath branch July 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: dependencies Issues or PRs about updating a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants