-
-
Notifications
You must be signed in to change notification settings - Fork 243
Bugfix/use write head instead of implicit header #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bjohansebas
merged 19 commits into
expressjs:master
from
Icehunter:bugfix/use_writeHead_instead_of_implicitHeader
Nov 13, 2024
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f160f44
Add failing tests for http2
2c8ed82
Add support for http2
8eae006
Remove arrow function in tests
8c68bc1
Conditionally run http2 tests if http2 is available
5122916
Fix port in tests to be assigned automatically
7b7f506
Change http2 test usage to describe.skip if no http2 available
8ba8100
Fix closing the http2 connections to prevent possible exceptions
8ea806d
Fix closing the request first, then the client, then the server
a562056
Fix closing for v8.x and v9.x
feddec1
fix tests not draining data for http2 requests, resulting in timeouts…
maritz 5124eb0
fix: 🐛 assert.equal error
Icehunter 094316e
fix: 🐛 remove console.log's and timeout, let build fail
Icehunter d85e6e8
Apply suggestions from code review
Icehunter d3016e2
fixed lint
Icehunter ebae4e9
fix: an issue where test hangs when assertion fails in http2 as http2…
lamweili 78cac20
refactor: use http2.constants instead of hard-coded strings in http2 …
lamweili 4c1d27b
Node.js 0.8 compatible
lamweili ec797a7
Merge branch 'master' into bugfix/use_writeHead_instead_of_implicitHe…
bjohansebas c126f78
fix lint issue
Icehunter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.