Fix double dot range for invalid input #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For double dot range i.e.,
a..b
wherea
andb
are inclusive when ranging froma
tob
. Therefore every element x in the range must satisfya <= x && x <= b
Previously, it used to panic because, for
a..b
,a
is considered minimum andb
is considered maximum which results in negative size when allocating memory for slice usingmake
. Ref:file: optimizer/const_range.go
So, for invalid inputs where a > b, it panics. Similar problem is there in
vm/runtime.go
'smakeRange
function as well.Changing it in the optimizer and makeRange seems apt to me, but I figured it could be handled in
checker/checker.go
and cry the error out loud that the expression is not correct, but it didn't feel right.@antonmedv What do you think? Having an empty slice instead of exiting out with an error seems good, right?
Fixes #163