Remove XCTest from custom-set #873
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
| {%- endif %} | ||
| } | ||
| {%- if subCases.property == "empty" %} | ||
| #expect(customSet.isEmpty == {{ subCases.expected|toBoolean }}) |
There was a problem hiding this comment.
I think it would look neater if the true ones are just left without the == true and those with false instead is replaced by a ! in the start of the expression
|
Nice, seems to have missed this one, and haven't thought about updating the plugin list. |
2 participants
Modern test runner does not support parsing old XCTest tests. So, for now in this problem all submission attempts will fail. Custom set is the last non-deprecated problem where XCTests is present. This PR converts the template and tests to Swift Testing.
What's more: add some required plugins to the generator and list all the plugins in readme. Some of them look weird, but it's another story.