Skip to content

Conversation

@ofhope
Copy link

@ofhope ofhope commented Apr 2, 2023

Going through this exercise I notice a fair bit of redundant testing. They loose value making it harder to establish the expected return.

  • Removed multiple tests for detects multiple anagrams
  • Removed multiple tests for anagrams must use all letters exactly once
  • Removed multiple test for case insensitive checking
  • Clarified test descriptions

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Apr 2, 2023
c())
})

test_that("detects simple anagram", {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no distinction between simple and complex anagrams. Removing this adjective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant